Skip to content

FIX: Bug located in primitives circuit module #6775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

FIX: Bug located in primitives circuit module #6775

wants to merge 13 commits into from

Conversation

@ramin4667
Copy link
Contributor

@ramin4667 ramin4667 commented Oct 16, 2025 •
edited
Loading

Description

**This PR fixes the error due to non-digit circuit element IDs. **

Issue linked

**The post-processing call for the simulated circuit of this example https://examples.aedt.docs.pyansys.com/version/dev/examples/high_frequency/radiofrequency_mmwave/lumped_element.html raises an error. **

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ramin4667 ramin4667 requested a review from a team as a code owner October 16, 2025 14:56
@ramin4667 ramin4667 requested a review from myoung301 October 16, 2025 14:57
@ramin4667 ramin4667 changed the title Bug located in primitives circuit module [FIX] Bug located in primitives circuit module Oct 16, 2025
@ramin4667 ramin4667 changed the title [FIX] Bug located in primitives circuit module FIX: Bug located in primitives circuit module Oct 16, 2025
@eblanco-ansys eblanco-ansys marked this pull request as draft October 16, 2025 15:01
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.49%. Comparing base (3241dff) to head (2896265).

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6775   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         245      245           
  Lines       77511    77511           
=======================================
+ Hits        64714    64718    +4     
+ Misses      12797    12793    -4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys marked this pull request as ready for review October 16, 2025 18:18
@gmalinve
Copy link
Contributor

gmalinve commented Oct 19, 2025

Hi @ramin4667 ,

Do you have an issue linked to this PR? if yes please link it.

Thanks,

KR,

Giulia

@gmalinve gmalinve linked an issue Oct 19, 2025 that may be closed by this pull request
Bug located in primitives_circuit module #6773
Open
2 tasks
@ramin4667
Copy link
Contributor Author

ramin4667 commented Oct 19, 2025

Hi @ramin4667 ,

Do you have an issue linked to this PR? if yes please link it.

Thanks,

KR,

Giulia

Hi @gmalinve, The PR is updated with a link to an issue.

@gmalinve
Copy link
Contributor

gmalinve commented Oct 19, 2025

Hi @ramin4667, yes. I linked it before.

myoung301
myoung301 requested changes Oct 20, 2025
View reviewed changes
myoung301
myoung301 approved these changes Oct 20, 2025
View reviewed changes
Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the other occurrences of setting id have been updated and the tests are passing still.

myoung301
myoung301 requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramin4667 There is at least one change needed for the tests. I saw a failure caused by the test looking for an int where the type is now a string. Please review the failing tests.

@ramin4667
Copy link
Contributor Author

ramin4667 commented Oct 31, 2025

@ramin4667 There is at least one change needed for the tests. I saw a failure caused by the test looking for an int where the type is now a string. Please review the failing tests.

@myoung301 Tests are updated and passing.

myoung301
myoung301 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@myoung301 myoung301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes and looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@myoung301 myoung301 myoung301 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug located in primitives_circuit module

5 participants

@ramin4667 @gmalinve @myoung301 @pyansys-ci-bot